Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prop): emit event when unset prop #2894

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

liujuping
Copy link
Collaborator

No description provided.

@liujuping liujuping requested a review from JackLian as a code owner January 26, 2024 09:01
@liujuping
Copy link
Collaborator Author

fixed #2741

Copy link

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.53% 25/172
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from 48c56ea

Copy link

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements
50.67% (-0.36% 🔻)
417/823
🔴 Branches
50.08% (-0.4% 🔻)
311/621
🔴 Functions
55.33% (-0.51% 🔻)
109/197
🔴 Lines
50.82% (-0.38% 🔻)
402/791
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 check-prop-types.ts
96.67% (-0.21% 🔻)
95.83% (-0.46% 🔻)
100%
96.3% (-0.26% 🔻)
🟡 logger.ts
70.49% (-3.28% 🔻)
44.83% (-3.45% 🔻)
64.29% (-7.14% 🔻)
70.49% (-3.28% 🔻)

Test suite run success

247 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from 48c56ea

Copy link

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.6% 906/1248
🟡 Branches 61.25% 569/929
🟡 Functions 69.78% 194/278
🟡 Lines 72.65% 890/1225

Test suite run success

96 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 48c56ea

Copy link

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements
93.95% (+0.01% 🔼)
2873/3058
🟢 Branches
87.81% (+0.03% 🔼)
1628/1854
🟢 Functions
93.42% (+0.01% 🔼)
866/927
🟢 Lines
94.09% (+0.01% 🔼)
2800/2976

Test suite run success

397 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from 48c56ea

@zboMa
Copy link

zboMa commented Jan 26, 2024

image

@JackLian JackLian merged commit e3a1989 into develop Jan 30, 2024
22 checks passed
@JackLian JackLian deleted the fix/prop-unset-event branch January 30, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants